Fix truncation of user-settings.yml by smartnode when ~/.rocketpool device is full
Who is the proposed retrospective award recipient?
patches.eth
What specific project or work is the retrospective award in recognition of? Please detail what the project or work entailed and the duration over which it took place.
PR: https://github.com/rocket-pool/smartnode/pull/411
Basically, smartnode had an issue that would manifest when a NO’s disk filled up.
If they ran rocketpool s c and saved, their settings would get erased from disk, and then writing the new settings would fail, leaving their node unconfigured. When this happened, their only recourse was to recover the smartnode backup settings file manually.
Because eth clients are wont to fill up the disk, this happened somewhat regularly, and delayed these NOs from coming back online.
I resolved the issue by writing the new settings to a temporary file before replacing the old settings, so we fail before we erase when the disk is full.
I probably spent an hour here.
Are the subjects of this award entirely open source (MIT, GPL, Apache, CC BY license or similar)? If not, which parts will not be, why, and under what license will they be published?
Smartnode is GPLv3
Benefits - enter N/A where appropriate
| Group | Benefits |
|---|---|
| Potential rETH holders | Meaninglessly improved apr |
| rETH holders | Meaninglessly improved apr |
| Potential NOs | Probably N/A unless they are monitoring #support for common issues |
| NOs | Faster recovery from full disk, more robust smartnode |
| Community | N/A |
| RPL holders | N/A |
Payment
How much USD $ is the applicant requesting be awarded to the recipient?
$100
Conflict of Interest
Does the person or persons requesting the retrospective award have any conflicts of interest to disclose? (Please disclose here if you are a member of the GMC or if you have nominated a member of the GMC for this retrospective award).
N/A