CID work by Patches during Round 8
Who is the proposed retrospective award recipient?
Patches - patches.eth
What specific project or work is the retrospective award in recognition of? Please detail what the project or work entailed and the duration over which it took place.
- Add local file abstraction for treegen and fix compression bugs with cid calculation by jshufro · Pull Request #432 · rocket-pool/smartnode · GitHub
- Don't omit totalNodeWeight if not set. Add a test to cement CID calculation. by jshufro · Pull Request #433 · rocket-pool/smartnode · GitHub
5 hours total
Following testing on Holesky, Fornax identified that the oDAO wasn’t coming to consensus. Joe messaged me about some behavior in my previous contribution of the CID calculator, and I discovered a few bugs had been introduced since the contribution (note- I do not want to point fingers, but I feel it is important the GMC knows I not adding bugs and then billing for the fixes- these bugs were not authored by me, though insofar as I believe bugs that make it into master are the collective responsibility of all who maintain a project and review its pull requests, I am not fully excused from responsibility).
I added an abstraction that makes the code “easier to hold” as we like to say (less likely to be used in a way that produces undesirable results). I also added some unit tests to smartnode to ensure that the abstraction remains intact and that the CIDs we get from the calculator match expectations.
Are the subjects of this award entirely open source (MIT, GPL, Apache, CC BY license or similar)? If not, which parts will not be, why, and under what license will they be published?
Yes - smartnode is GPLv3
Benefits - enter N/A where appropriate
- Resolved an issue threatening consensus for interval 18, like, just in time
- Code quality and reliability improvements for watchtower (odao) code
This one, again, is most benefiting Joe and Fornax, who have been scrambling.
Payment
How much USD $ is the applicant requesting be awarded to the recipient?
5 hours at $80 - total $400
Is the applicant requesting RPL or LUSD?
No preference. RPL if evenly convenient for the GMC.
Conflict of Interest
Does the person or persons requesting the retrospective award have any conflicts of interest to disclose? (Please disclose here if you are a member of the GMC or if you have nominated a member of the GMC for this retrospective award).
No